replace: fix build issues on GNU Hurd (#7998)
Kai Blin
kai.blin at gmail.com
Sun May 29 23:12:38 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2011-05-30 01:16, Andrew Bartlett wrote:
>> diff --git a/lib/replace/system/network.h b/lib/replace/system/network.h
>> index f7c1bcf..2ec9ebd 100644
>> --- a/lib/replace/system/network.h
>> +++ b/lib/replace/system/network.h
>> @@ -332,7 +332,7 @@ typedef unsigned short int sa_family_t;
>> */
>> # define IOV_MAX 512
>> # else
>> -# error IOV_MAX and UIO_MAXIOV undefined
>> +# warning IOV_MAX and UIO_MAXIOV undefined
>> # endif
>> # endif
>> #endif
>
> Is this really the right fix?
>
> Wouldn't this just shift the build failure to parts of Samba that rely
> on IOV_MAX?
Nope. As far as I can see IOV_MAX is only used in tsocket, where it's
inside an #ifdef and just loses the feature of checking if the iovec
passed to the readv/writev call is too big.
HTH,
Kai
- --
Kai Blin
Worldforge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk3jJ0YACgkQEKXX/bF2FpS98ACeOaq7ntpyPy2fZenUy/tMgS+A
GrUAn2HfjSbmqVEhPz/c66EJ0UMztLBz
=HI7c
-----END PGP SIGNATURE-----
More information about the samba-technical
mailing list