replace: fix build issues on GNU Hurd (#7998)

Andrew Bartlett abartlet at samba.org
Sun May 29 17:16:52 MDT 2011


On Mon, 2011-05-30 at 00:55 +0200, Björn Jacke wrote:
> The branch, master has been updated
>        via  a4d0362 replace: fix build issues on GNU Hurd (#7998)
>       from  c7c0e4c s3: Remove unused cli_session_request
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit a4d03620cb51638d1786c32b50953029752b7bc5
> Author: Björn Jacke <bj at sernet.de>
> Date:   Sun May 29 23:42:09 2011 +0200
> 
>     replace: fix build issues on GNU Hurd (#7998)
>     
>     Patch from Samuel Thibault <sthibault at debian.org> to fix Debian Bug 610678
>     resp. BSO #7998. IOV_MAX and UIO_MAXIOV are not defined on GNU Hurd.
>     
>     Autobuild-User: Björn Jacke <bj at sernet.de>
>     Autobuild-Date: Mon May 30 00:53:59 CEST 2011 on sn-devel-104
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  lib/replace/system/network.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/lib/replace/system/network.h b/lib/replace/system/network.h
> index f7c1bcf..2ec9ebd 100644
> --- a/lib/replace/system/network.h
> +++ b/lib/replace/system/network.h
> @@ -332,7 +332,7 @@ typedef unsigned short int sa_family_t;
>       */
>  #   define IOV_MAX 512
>  #  else
> -#   error IOV_MAX and UIO_MAXIOV undefined
> +#   warning IOV_MAX and UIO_MAXIOV undefined
>  #  endif
>  # endif
>  #endif

Is this really the right fix?  

Wouldn't this just shift the build failure to parts of Samba that rely
on IOV_MAX?

Andrew Bartlett

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org



More information about the samba-technical mailing list