[PATCH] Remove default panic action for --enable-developer
jra at samba.org
Thu Mar 24 11:24:37 MDT 2011
On Wed, Mar 23, 2011 at 11:15:56AM +1100, Andrew Bartlett wrote:
> This patch removes the default panic action for --enable-developer,
> which was previously 'sleep 999999'.
> This is a problem because like other #ifdef DEVELOPER things, it changes
> behaviour and makes reproducing customer problems more difficult. In
> this particular case, it meant it was more difficult to test the core
> dumping code, or to get a core file at all!
> If the developer (or user running with developer settings) knows that
> the sleep is in operation (because they set it), they can look for the
> deliberately stuck process. However if they don't know (a user running
> with developer settings to get better debugging), then it's just
> confusing to find resources such as the main socket and any locks etc
> still held open.
> What do others think?
I'm ambivalent :-). I always run with 'sleep 999999' as my panic action
in smb.conf so this won't affect me either way :-).
More information about the samba-technical