broken build on debian while searching for popt.h

[Jelmer Vernooij]

On Tue, 2011-03-15 at 20:30 +0300, Matthieu Patou wrote:
> [2266/2495] Compiling testsuite/headers/test_headers.c
> In file included from /usr/include/python2.6/Python.h:8,
> from ../testsuite/headers/test_headers.c:31:
> /usr/include/python2.6/pyconfig.h:1031:1: warning: "_POSIX_C_SOURCE" 
> redefined
> In file included from /usr/include/stdio.h:28,
> from ../testsuite/headers/test_headers.c:26:
> /usr/include/features.h:158:1: warning: this is the location of the 
> previous definition
> In file included from /usr/include/python2.6/Python.h:8,
> from ../testsuite/headers/test_headers.c:31:
> /usr/include/python2.6/pyconfig.h:1040:1: warning: "_XOPEN_SOURCE" redefined
> In file included from /usr/include/stdio.h:28,
> from ../testsuite/headers/test_headers.c:26:
> /usr/include/features.h:160:1: warning: this is the location of the 
> previous definition
> In file included from default/testsuite/headers/test_headers.h:60,
> from ../testsuite/headers/test_headers.c:37:
> default/include/public/samba/popt.h:23:18: error: popt.h: No such file 
> or directory
> In file included from default/testsuite/headers/test_headers.h:60,
> from ../testsuite/headers/test_headers.c:37:
> default/include/public/samba/popt.h:26: error: array type has incomplete 
> element type
> default/include/public/samba/popt.h:27: error: array type has incomplete 
> element type
> default/include/public/samba/popt.h:28: error: array type has incomplete 
> element type
> default/include/public/samba/popt.h:29: error: array type has incomplete 
> element type
> In file included from default/testsuite/headers/test_headers.h:63,
> from ../testsuite/headers/test_headers.c:37:
> default/include/public/security/access_check.h:66: warning: ‘struct 
> object_tree’ declared inside parameter list
> default/include/public/security/access_check.h:66: warning: its scope is 
> only this definition or declaration, which is probably not what you want
> default/include/public/security/access_check.h:72: warning: ‘struct 
> object_tree’ declared inside parameter list
> Waf: Leaving directory `/usr/local/src/samba/bin'
> 
> 
> installing libpopt-dev solves the problem, but as I understand we should 
> use the built-in version of libpopt when not told to do otherwise (or 
> when headers of this libs are not available).
We should not be installing popt.h since it's from a library we bundle,
but of course the local compile should still work. I wonder what the
best way is to fix this. Perhaps none of our public headers should
include popt.h?

Cheers,

jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110315/55dc71ba/attachment.pgp>