Carry error status in printer list IPC message

David Disseldorp ddiss at
Fri Mar 11 10:29:12 MST 2011


Currently the process forked to fetch printcap information from cups
does not include error status in its IPC message back to the parent.
As a result the parent is unable to differentiate between an empty
printer list and a failure to obtain the information from cups.

This patch-set converts the IPC message to an IDL defined format, which
includes the error status alongside the list of printers.

Cheers, David

The following changes since commit b738e092a22edb192243d2eee10c31a370be71e3:

  librpc/rpc: move dcerpc_binding_handle stuff to rpc_common.h (2011-03-11 12:28:08 +0100)

are available in the git repository at:
  git:// bso7994_cups_pcap_idl

David Disseldorp (4):
      idl: define printcap IPC message format
      s3-printing: use printcap IDL for IPC
      s3-printing: remove duplicate cups response processing code
      s3-printing: fix memory leak in print_cups.c

 librpc/idl/printcap.idl       |   17 ++
 librpc/idl/wscript_build      |    3 +-
 librpc/wscript_build          |    5 +
 source3/           |    2 +-
 source3/printing/print_cups.c |  442 +++++++++++++++++------------------------
 source3/wscript_build         |    3 +-
 6 files changed, 206 insertions(+), 266 deletions(-)
 create mode 100644 librpc/idl/printcap.idl

More information about the samba-technical mailing list