[PATCH REVIEW] s3-auth

Jeremy Allison jra at samba.org
Mon Jun 20 18:19:14 MDT 2011


On Thu, Jun 16, 2011 at 09:42:04PM +0200, Andreas Schneider wrote:
> Hello,
> 
> I have a patchset which touches s3-auth so it would be nice if someone of you 
> could review it.
> 
> The patchset does the following things:
> 
> * Reduces the dependencies (lp_load instead of reload_services,
>   smbd/globals.h).
> 
> * Introduces a new function get_remote_hostname().
> 
> * Removes the usage of the global variable smbd_server_conn from auth.
> 
> * Passes down the remote_address to the places where it is needed.
> 
> * Removes 'struct client_address' and replaces it with
>   'struct tsocket_address'
> 
> Every commit compiles for me and it passes make test here.
> 
> 
> Thanks for your time,

Andreas, where is the patchset hosted ?

Jeremy.


More information about the samba-technical mailing list