Reformatting code

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Jul 24 14:38:14 MDT 2011

On Sun, Jul 24, 2011 at 04:08:17PM +0200, Jelmer Vernooij wrote:
> >>On Fri, Jul 22, 2011 at 10:04:06AM +0200, Stefan (metze) Metzmacher wrote:
> >>>
> >>Yes, I know about that one. Has there been a resolution? I
> >>think even back then I replied with some doubtful mail. Has
> >>there been a definitive decision that this change is to be
> >>done?
> >No, but most of us thought it is a good idea to switch to
> >just one style of using bool values.
> Being consistent in the way we notate bools is definitely a good thing.
> That said, there is a difference between fixing up old-style bools in 
> code you are changing anyway, and actively reformatting code without 
> making any other changes.
> The latter makes it harder to track down its origin later, and adds 
> noise to our revision history: it makes things like "git annotate" or 
> "git log" harder to use. It's not worth the slight cosmetic improvement IMO.

That's exactly my point. If I change code lines anyway for
other reasons, then I also change False->false. But just for
the purpose of that change I leave it. But the two of us
seem alone with this opinion, everybody else sees it


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list