Reformatting code

Jelmer Vernooij jelmer at
Sun Jul 24 08:08:17 MDT 2011

On 22/07/11 11:14, Stefan (metze) Metzmacher wrote:
> Am 22.07.2011 10:35, schrieb Volker Lendecke:
>> On Fri, Jul 22, 2011 at 10:04:06AM +0200, Stefan (metze) Metzmacher wrote:
>> Yes, I know about that one. Has there been a resolution? I
>> think even back then I replied with some doubtful mail. Has
>> there been a definitive decision that this change is to be
>> done?
> No, but most of us thought it is a good idea to switch to
> just one style of using bool values.
Being consistent in the way we notate bools is definitely a good thing.

That said, there is a difference between fixing up old-style bools in 
code you are changing anyway, and actively reformatting code without 
making any other changes.

The latter makes it harder to track down its origin later, and adds 
noise to our revision history: it makes things like "git annotate" or 
"git log" harder to use. It's not worth the slight cosmetic improvement IMO.



More information about the samba-technical mailing list