s3-rpc_server: We need to copy the session_info for external pipes.

Andrew Bartlett abartlet at samba.org
Thu Jul 21 15:46:15 MDT 2011


On Thu, 2011-07-21 at 19:51 +0200, Andreas Schneider wrote:
> The branch, master has been updated
>        via  156a0ff s3-rpc_server: Create common function to allocate pipes_struct
>        via  759a04e s3-rpc_server: Move pipe/handles functions
>        via  0d8f65b s3-rpc_server: Fixed header define.
>        via  6a4a6ef s3-rpc_server: Remove unused endpoint information.
>        via  4a6a588 s3-rpc_server: We need to copy the session_info for external pipes.
>        via  19288f9 s3-rpc_server: Duplicate the pipe name.
>        via  3a43ef5 s3-rpc_server: Free the np dir.
>        via  304e811 s3-rpc_server: Fix messaging context in the pipes struct.
>        via  f5da8ed s3-rpc_server: Add my copyright.
>       from  71b49f5 s3:loadparm: fix an implicit cast warning in string intialization in init_globals()
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
.
> 
> commit 4a6a588e442e8b0880051c92af82eb0fd3bc7f99
> Author: Andreas Schneider <asn at samba.org>
> Date:   Thu Jul 21 17:58:41 2011 +0200
> 
>     s3-rpc_server: We need to copy the session_info for external pipes.
>     
>     Andrew please check!

This certainly seems harmless, so if you think it's required, then
that's fine.  Do you know how the lifetime of the session info ends up
being less than the time before it's marshalled onto the pipe?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org



More information about the samba-technical mailing list