[PATCH] common session_info structure

[Andrew Bartlett]

On Tue, 2011-07-19 at 10:59 +0200, Stefan (metze) Metzmacher wrote:

> I took a brief look and it looks very good (but I haven't explored it in
> all tiny details)

Thanks! 

> Do we need
> http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=8bb4871f451ec077126206a464142ee5a5d091ec
> in 3.6?

As far as I can tell, v3-6-test doesn't have the original patch
introducing the error in it.

> I guess some of this could fix (Andreas just confirmed it:-)
> https://bugzilla.samba.org/show_bug.cgi?id=8215

So, if I understand correctly from the clue in the bug:
 "I've found this bug with running spoolss as a seperate daemon." then
then this is exactly and entirely the purpose of the entire patch
series.  (You can't get the benefit without the full series).

With this patch series, the named pipe auth code no longer calls
create_local_token() in the RPC server.  create_local_token() does
indeed have a number of side-effects, including a multitude of lookups
and potentially user creation, and should only be called once per
session. 

I'm really glad to hear that this not only improves our code, it fixes
real world bugs too!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org