[PATCH] common session_info structure

Andreas Schneider asn at samba.org
Tue Jul 19 04:29:28 MDT 2011

On Tuesday 19 July 2011 10:59:51 Stefan  Metzmacher wrote:
> > I'd like to propose that this set of patches go in soon. I doubt
> > anyone is going to have the patience to do this again for a long time
> > if the patch set bit rots due to tree changes. So I'd suggest that
> > Andrew pushes this in a few days time based on my detailed review, but
> > I wanted to give you both a chance to look at this if you have time.
> I took a brief look and it looks very good (but I haven't explored it in
> all tiny details)
> Do we need
> http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=8bb4871f451ec
> 077126206a464142ee5a5d091ec in 3.6?
> I guess some of this could fix (Andreas just confirmed it:-)
> https://bugzilla.samba.org/show_bug.cgi?id=8215

I tested and reviewed the patchset. I didn't go into details just looked over 
everything. The patchset looks really good and it fixes an important issue 
which is blocking my work. I only found small things and typos.

You have a +1, good job!

	-- andreas

Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org

More information about the samba-technical mailing list