[PATCH] Add LoadParm optional parameter for Py_Credentials class constructor

Kamen Mazdrashki kamenim at samba.org
Wed Jan 26 13:04:28 MST 2011


Hi Jelmer,

Could you please take a look at following branch:
http://git.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/py-review

It is test to exploit a segfault when Py_Credentials object is used without
initializing 'domain' and 'workstation' members.

After a short discussion with abartlet, he prefers the fix to be
implemented in python layer via adding LoadParm parameter
for Credentials constructor.
This way Py_Credentials instances will get the chance to
call cli_credentials_guess() during construction to try to populate
cli_credentials structure fields.
Basically, most common pattern was:
  creds = Credentials()
  creds.guess(lp)
which now turns into just:
  creds = Credentials(lp)

-- 
CU,
Kamen Mazdrashki
Samba Team                                            http://samba.org
http://gitweb.samba.org/?p=kamenim/samba.git;a=summary


More information about the samba-technical mailing list