modification of userAccountControl according to MS-SAMR 3.1.1.8.1.
Matthias Dieter Wallnöfer
mdw at samba.org
Fri Jan 14 04:15:44 MST 2011
Here the same patch with the changed sam.py testsuite attached
(naturally sam.py has also been run against Windows). Please confirm
this if the patch looks okay and I will send it to autobuild soon.
Cheers,
Matthias
Matthias Dieter Wallnöfer wrote:
> Okay, here a patch proposal. Would you like to write some testcases
> for sam.py or should I take care of this?
>
> Cheers,
> Matthias
>
> Kamen Mazdrashki wrote:
>> Ah Matthias, sorry. I wasn't quite correct (I am clearly not thinking
>> very well these days. Perhaps I've lost my mind in 2010)
>>
>> We are passing 66080, which is 0x10220.
>> So, we have UF_PASSWD_NOTREQD already set.
>>
>> I think what is wrong with the code you've posted is that we are
>> checking _current_ value of userAccountControl.
>> While docs state that we should check _previous_ value for
>> userAccountControl.
>> When we are adding new record, we have no previous state, so I think
>> we should assume prev-userAccountControl = 0.
>>
>> I've never read MS-SAMR document (shame on me), so I wanted to
>> read it first, rather than proposing a patch for something I don't
>> understand.
>>
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110114/f3acab13/attachment.ksh>
More information about the samba-technical
mailing list