Typos in source4/scripting/bin/samba_backup

Matthieu Patou mat at samba.org
Fri Jan 7 14:59:26 MST 2011


Hi Micheal,
>> I agree that the samba_backup script should not back up all the data
>> on all of the shares, but just stuff that's necessary for Samba to
>> function properly.
>>
>> By the way, there are some typos in the script.  A variable called
>> relativedirname is set at the top of the loop, and then further down,
>> refativedirname and relativedirname are both used a few times.
>>
>> This probably works because you cd to $FROMWHERE before the loop and
>> the "find $refativedirname -name ..." expands to "find -name ..."
>> which is treated the same as "find . -name ..." by GNU find (but not
>> BSD find and the versions from proprietary UNIXes as far as I
>> remember.)
>>
>> I haven't tested to see what happens if I rename all instances of
>> refativedirname to relativedirname.
Thanks for your eagle's eye !

Can you either fill a bug of (better) provide us a patch I'll sign it off.

Matthieu



-- 
Matthieu Patou
Samba Team        http://samba.org
Private repo      http://git.samba.org/?p=mat/samba.git;a=summary




More information about the samba-technical mailing list