Typos in source4/scripting/bin/samba_backup

Michael Wood esiotrot at gmail.com
Fri Jan 7 04:57:16 MST 2011

Hi Matthieu

Not sure if you saw my e-mail.  I've changed the subject so as to make
it more visible (I hope).

On 5 January 2011 02:31, Michael Wood <esiotrot at gmail.com> wrote:
> Hi Matthieu
> On 4 January 2011 20:40, Matthieu Patou <mat at samba.org> wrote:
>> On 04/01/2011 20:11, Jelmer Vernooij wrote:
> [...]
>>> It also seems rather arbitrary to update the sysvol share contents but
>>> not the contents of any of the other shares.
> [...]
>> That being said, there is nothing that forbids to extend the backup of all
>> shares but I do think that having the possiblity not to backup all shares
>> but just sysvol is needed.
> I agree that the samba_backup script should not back up all the data
> on all of the shares, but just stuff that's necessary for Samba to
> function properly.
> By the way, there are some typos in the script.  A variable called
> relativedirname is set at the top of the loop, and then further down,
> refativedirname and relativedirname are both used a few times.
> This probably works because you cd to $FROMWHERE before the loop and
> the "find $refativedirname -name ..." expands to "find -name ..."
> which is treated the same as "find . -name ..." by GNU find (but not
> BSD find and the versions from proprietary UNIXes as far as I
> remember.)
> I haven't tested to see what happens if I rename all instances of
> refativedirname to relativedirname.

Michael Wood <esiotrot at gmail.com>

More information about the samba-technical mailing list