enable s3 waf build in autobuild
abartlet at samba.org
Mon Feb 28 20:09:07 MST 2011
On Tue, 2011-02-22 at 14:21 +1100, tridge at samba.org wrote:
> Hi All,
> Does anyone have any objections to us enabling the source3 waf build
> in autobuild? I'm thinking of making it do a build, but not run tests.
> The reason for enabling it now, is that it shares its build rules with
> the top level s3/s4 merged build. Ensuring that the s3 waf build keeps
> working will make life much easier for the current merge work.
> This would mean that all committers will need to fix any build issues
> with the source3 waf build that may arise on sn-devel, or autobuild
> will fail for your commit.
> We will still have the s3 autoconf build as well, so that means all
> committers will need to ensure any build rule changes are made in 2
> places for code that affects s3.
> The s3 waf build has been in the build farm for a few weeks now, and I
> think it is now reasonable to think of it as a "should not be broken"
I think we should also run the 'make test' as part of that. There may
be subtle differences in the way that the two different test systems
invoke selftest.pl, and it's important to test those, at least until the
top level build runs 'make test' across the entire tree.
I think we should also turn on the --enable-s3build option the top level
autobuild or by default in master. This build likewise needs to stay
working, and if we make it the default in master, this should not be a
My preference is for us to have --enable-s3build be the default in
master, so that all the binaries are built all the time, and so I can
start on an integrated 'make test'.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
More information about the samba-technical