ldb python bindings

Jelmer Vernooij jelmer at samba.org
Sat Feb 19 12:30:00 MST 2011


On Sun, Feb 20, 2011 at 08:24:04AM +1100, Andrew Bartlett wrote:
> On Sat, 2011-02-19 at 19:18 +0300, Matthieu Patou wrote:
> > Hello Andrew (T), Andrew (B) and Jelmer,
> > 
> > Here at 
> > http://git.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/pybindings
> > I have a couple of patches for making ldb.search(...) returning an 
> > object and not only a list of ldb_message so that we can access controls 
> > and referrals as well.
> > 
> > Following the remarks of Tridge I moved the ldb_control to string in 
> > pyldb.c and now jelmer is asking me to do the opposite.
> > 
> > Can you give a final version and if it can avoid me one more time to 
> > rewrite the whole stuff it would be just perfect !
> I think that Jelmer and I would be in agreement that the patch as is
> looks great, but that you just need to put the ldb_control_to_string()
> function, as is, into ldb_controls.c code, as a private function (no
> need to add it to the public headers at this point).
Yep. 

Actually, the function will have to be public, as pyldb only uses the
public interface of libldb. That doesn't seem to bad though, as
a way to serialize controls might be useful to other ldb users
as well.

Cheers,

Jelmer


More information about the samba-technical mailing list