ldb python bindings

Andrew Bartlett abartlet at samba.org
Sat Feb 19 14:24:04 MST 2011

On Sat, 2011-02-19 at 19:18 +0300, Matthieu Patou wrote:
> Hello Andrew (T), Andrew (B) and Jelmer,
> Here at 
> http://git.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/pybindings
> I have a couple of patches for making ldb.search(...) returning an 
> object and not only a list of ldb_message so that we can access controls 
> and referrals as well.
> Following the remarks of Tridge I moved the ldb_control to string in 
> pyldb.c and now jelmer is asking me to do the opposite.
> Can you give a final version and if it can avoid me one more time to 
> rewrite the whole stuff it would be just perfect !

I think that Jelmer and I would be in agreement that the patch as is
looks great, but that you just need to put the ldb_control_to_string()
function, as is, into ldb_controls.c code, as a private function (no
need to add it to the public headers at this point).

The new structure that creates ldb controls as LdbControl objects looks
great, and I'm very pleased not to have the array of output strings any

You should probably expose privately a new ldb_parse_control_string that
takes just one string (which would then be wrapped by
ldb_parse_control_strings()) to avoid needing to go via the array on the
input side. 

There are couple of of minor formatting issues, and I've not done a
formal review, but I wanted to assure you that we are not in as much a
disagreement as you feared. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

More information about the samba-technical mailing list