[PATCH 2/7] ldb:ldbdel tool - use LDB result constants for consistency

simo idra at samba.org
Tue Feb 1 09:42:59 MST 2011


On Tue, 2011-02-01 at 17:37 +0100, Matthias Dieter Wallnöfer wrote:
> Yeah simo,
> 
> I agree. But which method do you prefer? "-1" or LDB errors?
> 
> Then, after this has been cleared I'm willing to rework my patches to 
> comply with the decision.

Given it has been inconsistent for more than a year now, I have no
preference, unless someone is depending on the return value in some
scripts, like automatic testing.

If nobody is depending on it then I would be ok with returning LDB error
codes

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list