[PATCH] KCC intrasite topology generator advancement

[Matthieu Patou]

Hi Dave,

On 04/12/2011 22:02, Dave Craft wrote:
> Tridge, Samba Team,
>
> The patchsets available at
>       https://github.com/wimberosa/samba/tree/kcc-stable
> are now available for review and integration if acceptable.
>
> The crux of these changes gets samba_kcc to properly commit
> repsFrom for each NC replica that is implied by an NTDS Connection.
> All attributes (e.g. DRS options, schedules, etc.) are now properly
> maintained in repsFrom creations.
I didn't had a deep look at your patch but it's very good that someone 
started to tackle this subject !

Did your patch take care to periodically check if the ISTG attribute has 
been updated, to update it if the DC is the ISTG and to try to promote 
as ISTG if the previous one.
I noticed lately that when dealing with more than 1 site and with mixed 
(Samba and Microsoft) DCs it's important to correctly manage this attribute.


> Additionally the samba_kcc is now invocable from the daemon and
> can be configured instead of kccsrv_simple_update (e.g. can be
> invoked instead of the older kcc topology generator).  More detail
> noted in the check in comments appended below:

Good, if I'm not misunderstanding it's the KCC tasks to periodically 
send DsAddRef in order that other DC add or update their repsTo is it in 
your patchset ?

Matthieu.

-- 
Matthieu Patou
Samba Team
http://samba.org