Expanding the number of socket wrapper interfaces

[Andrew Bartlett]

On Mon, 2011-04-18 at 14:07 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> > As part of my work in combining 'make test' to cover all of Samba at
> > once, I need more than 16 socket wrapper interfaces.  (We have 15
> > different servers starting, plus 6 interfaces reserved for the client at
> > the moment, and that's before we start testing between the codebases). 
> > 
> > The problem is, the current code is cryptically limited to 16 because of
> > IRIX 6.4 support.  
> > 
> > The last release of IRIX was in 2006 according to wikipedia, and SGI
> > isn't in much better shape, but we have supported it for a long time, we
> > have a reliable build farm host for it and it currently shows passing
> > results.
> > 
> > Does anyone know if the limit only applied to IRIX 6.4 or also applies
> > to IRIX 6.5 that we have in the farm?
> 
> The IRIX related comment only applies to SOCKET_FORMAT.
> 
> The limit for MAX_WRAPPED_INTERFACES == 16 is different from the limit of 16
> characters in the path name on IRIX.
> 
> MAX_WRAPPED_INTERFACES was 254 before, but it means we need to do 254 stat()
> calls per broadcast sendto(), that's why we reduced it to 16.
> 
> I think we can change MAX_WRAPPED_INTERFACES to 32 for now.

Are those stats particularly expensive in our testsuite?  Do we
broadcast that often?

For the programmer it's quite unexpected when you find that addressed
higher than a magic value like 16 just don't work...

Anyway, 32 will get us out of trouble for now, but I would prefer 64 or
just the whole last octet.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org