[PATCH] s4 libcli: fix NTLMv2 without spnego

Christian M Ambach christian.ambach at de.ibm.com
Wed Apr 13 05:36:58 MDT 2011


Hi Metze,

"Stefan (metze) Metzmacher" <metze at samba.org> wrote on 04/13/2011 01:01:45 
PM:

> Hi Christian,
> 
> can you use a helper variable for the domain? This looks a bit ugly:
> 
> +   DATA_BLOB names_blob =
> +      NTLMv2_generate_names_blob(state, NULL,
> +                  cli_credentials_get_domain(
> +                  io->in.credentials
> +                  )
> +                 );
> 
> 
> This would look much nicer:
> 
>    const char *domain = cli_credentials_get_domain(io->in.credentials);
>    DATA_BLOB names_blob = NTLMv2_generate_names_blob(state, NULL, 
domain);
> 

sure :)

Updated patchset attached.

Regards,
Christian


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-libcli-do-not-announce-NT-error-code-support-when.patch
Type: application/octet-stream
Size: 1027 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110413/3264f295/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libcli-allow-exclusion-of-netbios-name-in-NTLMV2-blo.patch
Type: application/octet-stream
Size: 1243 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110413/3264f295/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-libcli-do-not-use-netbios-name-in-NTLMv2-blobs-w-.patch
Type: application/octet-stream
Size: 2969 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110413/3264f295/attachment-0002.obj>


More information about the samba-technical mailing list