[PATCH] s4 libcli: fix NTLMv2 without spnego

Andrew Bartlett abartlet at samba.org
Wed Apr 13 17:29:37 MDT 2011


On Wed, 2011-04-13 at 13:36 +0200, Christian M Ambach wrote:
> Hi Metze,
> 
> "Stefan (metze) Metzmacher" <metze at samba.org> wrote on 04/13/2011 01:01:45 
> PM:
> 
> > Hi Christian,
> > 
> > can you use a helper variable for the domain? This looks a bit ugly:
> > 
> > +   DATA_BLOB names_blob =
> > +      NTLMv2_generate_names_blob(state, NULL,
> > +                  cli_credentials_get_domain(
> > +                  io->in.credentials
> > +                  )
> > +                 );
> > 
> > 
> > This would look much nicer:
> > 
> >    const char *domain = cli_credentials_get_domain(io->in.credentials);
> >    DATA_BLOB names_blob = NTLMv2_generate_names_blob(state, NULL, 
> domain);
> > 
> 
> sure :)
> 
> Updated patchset attached.

I've signed off on this and pushed it to autobuild.

Thanks for your patience on this!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org



More information about the samba-technical mailing list