[PATCH REVIEW REQUEST] become_user_by_session
asn at samba.org
Fri Apr 8 04:39:06 MDT 2011
On Tuesday 05 April 2011 23:14:57 Andrew Bartlett wrote:
> On Tue, 2011-04-05 at 17:24 +0200, Andreas Schneider wrote:
> > Hi,
> > there is problem here if we connect to spoolss over another transport
> > than ncacn_np. There will be no real connection_struct and thus no vuid.
> > This means we need a become_user_by_session() using the
> > auth_serversupplied_info to do the VFS work.
> > http://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/s3-fixes
> > Volker and Simo had a quick look and Volker said he will do a complete
> > review as soon as he has time. He told me to ask you two for review too
> > :)
> Thanks for posting this here. This looks like a really good improvement
> of the abstractions here.
> I have a couple of little things I noticed:
> I would prefer that these were either left out or put as SMB_ASSERT().
> You have just added the only caller, which has this correct, and much
> existing code in the stack above those callers already relies on these
> not being NULL.
It is an SMB_ASSERT now. Still waiting for comments or an approval from Jeremy
Andreas Schneider GPG-ID: F33E3FC6
Samba Team asn at samba.org
More information about the samba-technical