[PATCH REVIEW REQUEST] become_user_by_session
Andrew Bartlett
abartlet at samba.org
Tue Apr 5 15:14:57 MDT 2011
On Tue, 2011-04-05 at 17:24 +0200, Andreas Schneider wrote:
> Hi,
>
> there is problem here if we connect to spoolss over another transport than
> ncacn_np. There will be no real connection_struct and thus no vuid. This means
> we need a become_user_by_session() using the auth_serversupplied_info to do
> the VFS work.
>
> http://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/s3-fixes
>
> Volker and Simo had a quick look and Volker said he will do a complete review
> as soon as he has time. He told me to ask you two for review too :)
Thanks for posting this here. This looks like a really good improvement
of the abstractions here.
I have a couple of little things I noticed:
I would prefer that these were either left out or put as SMB_ASSERT().
You have just added the only caller, which has this correct, and much
existing code in the stack above those callers already relies on these
not being NULL.
+ if (conn == NULL) {
+ DEBUG(2,("No connection provided!\n"));
+ return false;
+ }
+
+ if (session_info == NULL) {
+ DEBUG(2,("No session info provided!\n"));
+ return false;
+ }
+
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
>
More information about the samba-technical
mailing list