[PATCH] s4-drs: A quick fix for DRSUAPI_EXOP_FSMO_RID_ALLOC extended_op handling

[Andrew Bartlett]

On Fri, 2010-09-03 at 13:16 +0300, Kamen Mazdrashki wrote:
> 
> 
> On Fri, Sep 3, 2010 at 12:50, Andrew Bartlett <abartlet at samba.org>
> wrote:
>         
>         OK, that seems quite reasonable.  But if it's in a
>         transaction, how do
>         we get the 'extra' responses you are worried about?
>         
> Here is what happens:
> 1. dcesrv_DsGetNCChanges() gets called to allocate a rid pool
> 2. while allocating new rid pool we have
>    2.1. transaction_start
>    2.2. get highest USN
>    2.3. allocate rid pool
>    2.4. transactin_commit
> 3. right after transaction_commit, we have a new object added 
>     (this usually happens while object-add-intensive test is running
> - 
>      samba4.rpc.samr.large.dc.one for instance)
> 4. GetNCChanges() continues with building the list of objects to
> return and voila,  
>    we get objects added in (3) in that list
> 
> 
> This should be no big deal, it is just not what windows will do :)

Why can't the transaction last until after the search?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100903/93fea4e1/attachment.pgp>