[PATCH] s4-drs: A quick fix for DRSUAPI_EXOP_FSMO_RID_ALLOC extended_op handling

[Kamen Mazdrashki]

On Fri, Sep 3, 2010 at 12:50, Andrew Bartlett <abartlet at samba.org> wrote:

> OK, that seems quite reasonable.  But if it's in a transaction, how do
> we get the 'extra' responses you are worried about?
>
> Here is what happens:
1. dcesrv_DsGetNCChanges() gets called to allocate a rid pool
2. while allocating new rid pool we have
   2.1. transaction_start
   2.2. get highest USN
   2.3. allocate rid pool
   2.4. transactin_commit
3. right after transaction_commit, we have a new object added
    (this usually happens while object-add-intensive test is running -
     samba4.rpc.samr.large.dc.one for instance)
4. GetNCChanges() continues with building the list of objects to return and
voila,
   we get objects added in (3) in that list

This should be no big deal, it is just not what windows will do :)


-- 
CU,
Kamen Mazdrashki
Samba Team                                            http://samba.org
http://gitweb.samba.org/?p=kamenim/samba.git;a=summary