[SCM] Samba Shared Repository - branch master updated

[Björn JACKE]

On 2010-10-02 at 11:17 +0200 Volker Lendecke sent off:
> commit fc6e910e69f49cd482966eb9af3f27c0b65bcf4b
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sat Oct 2 11:13:34 2010 +0200
> 
>     s3: Fix a 64-bit BUG
>     
>     Quick explanation why this is a problem:
>     
>     It is not safe to pass a pointer to a uint32_t into a routine that expects
>     a size_t *. The routine that this pointer is passed to has no chance to find
>     out that in reality it was passed a pointer to a uint32_t. On platforms where
>     sizeof(size_t)==8, we get a nice overwrite of a stack area that should not
>     be overwritten.
>     
>     As this happens over an over again: Does someone know a means to make gcc
>     stop with an error in this case?

if it's the error warning that I assume it was, then it's not possible with gcc, see
http://blog.flameeyes.eu/2008/11/13/gcc-features-and-shortcomings and
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37866

we might turn that warning into errors on some of the Unix compilers though. As
all of us take the broken build mails very serious¹ these errors should be
recogniced soon after checkin ;-)

Cheers
Björn

¹) see http://build.samba.org/?tree=samba_3_master&function=Recent+Builds
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101002/3ca10405/attachment.pgp>