dns.idl ==> build breaks on non-ipv6 systems

Michael Adam obnox at samba.org
Sat Nov 6 04:14:45 MDT 2010

Stefan (metze) Metzmacher wrote:
> Am 06.11.2010 09:21, schrieb Matthieu Patou:
> > Hi Michael,
> > 
> > 
> >> Hi Kai and list,
> >>
> >> it seems the introduction of the dns server in s4
> >> has broken the build on non-ipv6 systems by using
> >> AD_INET6 unconditionally in the pull/push/print_ipv6
> >> functions in ndr_basic.c
> >>
> >> Since these functions are in ndr_basic.c this also
> >> breaks the build of s3 on non-ipv6-systems.
> >>
> >> Attached find a patch that moves these 3 functions
> >> to a new module ndr_ipv6.c that is only used in s4.
> > Why not make a fix that do it correctly also for samba4 on non ipv6
> > systems ?
> Yes, this code should not use inet_pton, it should work
> also on non ipv6 hosts.

Certainly, as I wrote, this needs proper fixing for s4.
(Mathieh has cleverly cut out that bit of my mail.. ;-)
But since the code only affects the s4 build,
I thought I'd just move it to a place of their own, so
that the piece of code that needs fixing is more isolated
and more obsolete.

I have to admit that I could or should have proposed a proper
fix right away, but firstly I do not know the s4 dns code
yet, and sencondly, I was sitting in the airport waiting
for boarding the plane and just wanted to fix the s3 build. ;-)

And what is so bad in not linking these (in s3)unused functions
into s3 after all?

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101106/297e2c20/attachment.pgp>

More information about the samba-technical mailing list