dns.idl ==> build breaks on non-ipv6 systems

Stefan (metze) Metzmacher metze at samba.org
Sat Nov 6 03:46:51 MDT 2010

Am 06.11.2010 09:21, schrieb Matthieu Patou:
> Hi Michael,
>> Hi Kai and list,
>> it seems the introduction of the dns server in s4
>> has broken the build on non-ipv6 systems by using
>> AD_INET6 unconditionally in the pull/push/print_ipv6
>> functions in ndr_basic.c
>> Since these functions are in ndr_basic.c this also
>> breaks the build of s3 on non-ipv6-systems.
>> Attached find a patch that moves these 3 functions
>> to a new module ndr_ipv6.c that is only used in s4.
> Why not make a fix that do it correctly also for samba4 on non ipv6
> systems ?

Yes, this code should not use inet_pton, it should work
also on non ipv6 hosts.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101106/8cd5eaf2/attachment.pgp>

More information about the samba-technical mailing list