s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000

[Matthias Dieter Wallnöfer]

Hi abartlet,

sorry for the noise but I basically pushed a slightly modified variation 
of your patch, Andrew. And thought that this would be fine for you. And 
yes, it's not a definite solution - since as I stated in the commit 
comment - we need to implement full server signing to cover all aspects.

Matthias

Stefan (metze) Metzmacher wrote:
> Am 30.05.2010 13:07, schrieb Andrew Bartlett:
>    
>> On Sun, 2010-05-30 at 05:41 -0500, Matthias Dieter Wallnöfer wrote:
>>      
>>> The branch, master has been updated
>>>         via  1cf5be3... s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000
>>>        from  76cd237... s4:web_server/wsgi.c - free the "env" and "inputstream" objects on an "asprintf" failure
>>>
>>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>>
>>>
>>> - Log -----------------------------------------------------------------
>>> commit 1cf5be39e30f9478606a5525eb7beeb21ee83c24
>>> Author: Matthias Dieter Wallnöfer<mdw at samba.org>
>>> Date:   Sun May 30 12:02:24 2010 +0200
>>>
>>>      s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000
>>>
>>>      Windows 2000 does strictly request header signing on some requests also if the
>>>      server doesn't provide it. But there is a small trick (don't reset the actual
>>>      session info) to make these special RPC operations work without a full header
>>>      signing implementation.
>>>
>>>      This fixes for example the list of domain groups in local groups when displayed
>>>      sing the local user/group management tool.
>>>
>>>      And this should finally fix bug #7113.
>>>
>>>      The patch was inspired by another one by tridge and abartlet: http://gitweb.samba.org/samba.git/?p=tridge/samba.git;a=commitdiff;h=2dc19e2878371264606575d3fc09176776be7729
>>>        
>> Matthias,
>>
>> I'm not comfortable with this path, and would have liked a chance to
>> review it before you put it in.
>>      
> Yes, me too... I believe this change is wrong.
>
> metze
>
>