Commit 086c6c0e9a56f7e6dca6c1398e210b8c6225e4ed

[Björn Jacke]

On 2010-05-27 at 06:59 +0200 Stefan (metze) Metzmacher sent off:
> > the changed version of this commit doesn't do what the previous one did and
> > breaks some builds like the one on Tru64. In the worst case others might have
> > silently broken thread support now. The previous version was intended to set
> > CFLAGS for the compiles of certain object files that need it. Other object
> > files may not have that CFLAGS, that's why it's not allowed to set them
> > globally. I know that this was written in a GNU make fashion but we had known
> > GNU make dependencies also on other places in the past. I'd love to write this
> > object file based CFLAGS up in a non GNU way but I don't know how. Before we
> > end up with broken thread support I'd propose to reintroduce the gmake
> > dependency again (at least for now...).
> 
> Can't that be solved in the same way we build dynconfig.o with different
> CFLAGS?

yes that should also work. I thought the number of object files that are
affected is much higher but we have actually just four of them, so it looks
manageable to add separate targets for them. We should probably better go this
way to would avoid the GNU make dependency at this place.

Björn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100527/5df8f8a8/attachment.pgp>