Patches for DFS implementation

[Stefan (metze) Metzmacher]

Matthieu Patou schrieb:
> Hi Metze,
> Thank for your tests.
> I'm a bit puzzled, as your trace show that requestedname is
> \samba.example.com\sysvol
> 
> #14 0x00000000006edbab in dodc_or_sysvol_referral (ctx=0x1e24e30, dfsreq=
>       {max_referral_level = 4, servername = 0xe47f90
> "\\samba.example.com\\sysvol"}, requestedname=0xe47f90
> "\\samba.example.com\\sysvol", ldb=0xb03d70,
>     trans=0x24709d0, req=0x174f370, lp_ctx=0xae8820)
>     at ../smb_server/smb/trans2.c:1484
>         nb_entries = 1
>         current = 1
> 
> And in the code of dodc_or_sysvol_referral the parameter is passed
> without modification (well normally)
>                                 status =
> fill_normal_dfs_referraltype(referral,
>                                                
> dfsreq.max_referral_level, requestedname,
>                                                
> talloc_asprintf(referral,"\\%s\\%s",set[i]->names[j],share), j==0);
> 
> and the error in your trace is at
> #8  0x00000000005c2219 in ndr_push_dfs_normal_referral (ndr=0x1e19910,
>     ndr_flags=2, r=0x2860a88) at default/librpc/gen_ndr/ndr_dfsblobs.c:384
>         _status = 32767
>         _flags_save_string = 2
> 
> It's when pushing DFS_path which is in fact requestedname.
> 
> I tried running this with valgrind and found errors of course but they
> were due to bad parenting and occured after talloc_free(context) when
> your occured before.
> In anycase now valgrind is clean.
> 
> I attached a patch for fixing error can you try it and tell me if you
> still have pbs ?

it still crashes

metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: out2.txt.gz
Type: application/x-gzip
Size: 11352 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100514/5129296f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100514/5129296f/attachment.pgp>