[PATCH] s4-drs: Delete RODC filtered attributes from objects

[Anatoliy Atanasov]

Hi Andrew,

Last changes are in: http://git.samba.org/?p=anatoliy/anatoliy.git;a=commit;h=6b71be1510f391a014347e4d4dd595294c674618

> -----Original Message-----
> From: Andrew Bartlett [mailto:abartlet at samba.org]
> Sent: Thursday, March 25, 2010 06:02
> To: Anatoliy Atanasov
> Cc: tridge at samba.org; samba-technical at lists.samba.org
> Subject: RE: [PATCH] s4-drs: Delete RODC filtered attributes from objects
> 
> On Wed, 2010-03-24 at 17:47 +0200, Anatoliy Atanasov wrote:
> > Hi Team,
> >
> > I am working on the check for read-only database when we are RODC. I
> > pushed the change here:
> >
> http://git.samba.org/?p=anatoliy/anatoliy.git;a=commit;h=7004efe1a84f3f289
> f037f282005fd89ab4b5fe0
> > Can somebody review it? I added a check in replmd_update_rpmd. The
> > goal is to return a referral if RODC database is being modified. The
> > result here is that ldb_module_send_referral doesn't work as I
> > expected and what we return is Operational Error.
> 
> Have a look at the 'partitions' module for how to send referrals
> correctly.  Here mdw did some work to send referrals, and I hope you
> will be able to follow the same pattern.
The partition module returns the referrals in the callback, so I kind off can't get the same behavior in the replmd_modify.
 
> In short, you need to send the referral, and the error back.
> 
> Also, it is incorrect to do:
> 
>  req->op.search.scope == LDB_SCOPE_ONELEVEL ? "??base" : ""
> 
> When 'req' is a modify, not a search operation.
Fixed, but the referral value isn't propagated by ldb_module_done, ldb_module_send_referral and I can't figure out how to make it appear in the response. 

Any suggestions?

Thanks,
Anatoliy

 
> Andrew Bartlett
> 
> --
> Andrew Bartlett                                http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Cisco Inc.