[PATCH] s4: initial code for the topology algorithm

Stefan (metze) Metzmacher metze at samba.org
Fri Mar 12 09:20:46 MST 2010


Hi Crístian,

Do we generate the connection objects for each dc in our site now?
At least that's my impression after reading the master which are in
master now.

I think each dc needs to generate only it's own intra-site connections.

metze

>  > When you sent this e-mail I was nearly at the end of that algorithm, so I
>  > decided to finish it. I took a couple of days reviewing the code and testing
>  > it, and only today I could send the patches. 
> 
> That's fine, I think what you have done looks good, and it doesn't
> seem to cause any problems, so I will push it soon (I'm just waiting
> on a full test to finish).
> 
>  > It isn't fully functional as there are some parts I don't know how
>  > to implement. Those parts have TODO comments explaining what should
>  > be done that I didn't understand.
> 
> The only TODO I see is this:
> 
> 		/* TODO: don't need to ldb_search again; search in res. */
> 		ret = ldb_search(ldb, tmp_ctx, &res_site_link, base_dn,
> 				 LDB_SCOPE_SUBTREE, attrs,
> 				 "objectClass=siteLink");
> 
> which seems to be just an efficiency thing. Do you think the rest of
> the algorithm is clear enough for you now?
> 
> Cheers, Tridge


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100312/d323512d/attachment.pgp>


More information about the samba-technical mailing list