[PATCH] s4: initial code for the topology algorithm
tridge at samba.org
tridge at samba.org
Thu Mar 11 22:17:16 MST 2010
Hi Crístian,
> When you sent this e-mail I was nearly at the end of that algorithm, so I
> decided to finish it. I took a couple of days reviewing the code and testing
> it, and only today I could send the patches.
That's fine, I think what you have done looks good, and it doesn't
seem to cause any problems, so I will push it soon (I'm just waiting
on a full test to finish).
> It isn't fully functional as there are some parts I don't know how
> to implement. Those parts have TODO comments explaining what should
> be done that I didn't understand.
The only TODO I see is this:
/* TODO: don't need to ldb_search again; search in res. */
ret = ldb_search(ldb, tmp_ctx, &res_site_link, base_dn,
LDB_SCOPE_SUBTREE, attrs,
"objectClass=siteLink");
which seems to be just an efficiency thing. Do you think the rest of
the algorithm is clear enough for you now?
Cheers, Tridge
More information about the samba-technical
mailing list