Recycle Bin activation test cases

[Eduardo Lima]

Hi Tridge,

Should I send the Recycle Bin activation test cases as a [PATCH] submission
email? I didn't make any other changes on it.

Were there any changes on the provision that could affect the procedure to
increase the functional level? After changing the
domainControllerFunctionality to DS_DC_FUNCTION_2008_R2 I can still enable
the Recycle Bin successfully, but now I get a functional error message
during the vampire:

The servers function level 4 is above 'ads:dc function level' of 3
libnet_BecomeDC() failed - NT_STATUS_NOT_SUPPORTED
Vampire of domain failed: NT_STATUS_NOT_SUPPORTED

This error during the vampire is different from the error I was having last
week.

While I can't make it work, I'm going to start the implementation of a
function to check if a given optional feature is enabled or not.

About making the "make test"  to run on a higher functional level, I was
thinking about to find out where the provision for the "make test" is done
to ask for a higher level, but it will fail
since domainControllerFunctionality would be different, right? I still need
to look deeper on it, but some pointers are welcome.

Thanks!

--
Eduardo Lima


On Wed, Feb 24, 2010 at 23:00, <tridge at samba.org> wrote:

> Hi Eduardo,
>
>  > I have implemented the recycle bin activation test cases:
>  >
> http://repo.or.cz/w/Samba/eduardoll.git/commit/8dad1f8811322e1a474343b9bb06139138cde5d3
>
> This is really nice, thanks! You're really starting to get the hang of
> our python test suites.
>
>  > 1 - I wrote the test cases in the same file of the deletion test cases:
>  > deletetest.py as a new test class. Is it better to move it to a new
> file?
>
> I think it's fine in the same file.
>
>  > 2 - Once recycle bin is activated it can't be deactivated. So, after the
>  > tests, the sam.ldb database will have the Recycle Bin enabled. Is there
> a
>  > way to rollback the database to the previous state?
>
> we could, but I don't think we need to. Having the recycle bin enabled
> should not break any of our other tests.
>
>  > 3 - It only runs on 2008_R2 functional level, that is not the samba's
>  > default level.
>
> I think at this stage we should switch over Samba4 in 'make test' to
> default to the 2K8_R2 functional level. That means we need to modify
> the provision slightly to make the --function-level option to
> provision work with the R2 level, then we need to make the provision
> done in 'make test' use that level.
>
> Do you want to start looking at that, or do you want some pointers on
> how to do it?
>
>  > Vampire of domain failed: Connection to SAMR pipe of PDC for
>  > adr2.ltc.inovasoft.unicamp.br failed: Connection to DC failed:
>  > NT_STATUS_IO_TIMEOUT
>
> hmm, I don't know what would be causing this. Can you put a more
> complete log somewhere, and maybe a wireshark capture?
>
> Cheers, Tridge
>