[SCM] Samba Shared Repository - branch master updated

[Jelmer Vernooij]

Hi Matthias,

On Fri, 2010-06-25 at 01:49 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
> commit 408a3aa3085e783523ed80bb328a3c65159900ab
> Author: Matthias Dieter Wallnöfer <mdw at samba.org>
> Date:   Thu Jun 24 16:06:11 2010 +0200
> 
>     s4:lib/registry/ldb.c - cosmetic - fix comment
> 
> commit 14386e6ec50b55039be6a719a17b185e651ee025
> Author: Matthias Dieter Wallnöfer <mdw at samba.org>
> Date:   Thu Jun 24 16:05:31 2010 +0200
> 
>     s4:lib/registry/ldb.c - cosmetic - wrap lines
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source4/lib/registry/ldb.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source4/lib/registry/ldb.c b/source4/lib/registry/ldb.c
> index 2310bab..01d82e2 100644
> --- a/source4/lib/registry/ldb.c
> +++ b/source4/lib/registry/ldb.c
> @@ -329,8 +329,8 @@ static WERROR cache_subkeys(struct ldb_key_data *kd)
>  	struct ldb_result *res;
>  	int ret;
>  
> -	ret = ldb_search(c, c, &res, kd->dn, LDB_SCOPE_ONELEVEL, NULL, "(key=*)");
> -
> +	ret = ldb_search(c, c, &res, kd->dn, LDB_SCOPE_ONELEVEL,
> +			 NULL, "(key=*)");
>  	if (ret != LDB_SUCCESS) {
>  		DEBUG(0, ("Error getting subkeys for '%s': %s\n",
>  			ldb_dn_get_linearized(kd->dn), ldb_errstring(c)));
Is this sort of change really necessary ? I don't see how this is
cosmetically better than what it was previously. It also didn't overrun
the 80 character boundary (as set by our coding style). This just makes
it harder to read the output of "git blame"; please refrain from changes
like this, at least in lib/registry. 

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100625/09e6a312/attachment.pgp>