LDB hidden memory leaks

[Stefan (metze) Metzmacher]

Am 10.07.2010 11:35, schrieb Michael Wood:
> Hi
> 
> On 10 July 2010 10:16, Stefan (metze) Metzmacher <metze at samba.org> wrote:
>> Hi Kamen,
>>
>>> I think I am done with ldb refactoring for now
>>> (at least, we should get a lot less leaked ldb_msg objects during
>>> provisioning)
>>>
>>> I will appreciate if you find some spare time to review my branch at:
>>> http://gitweb.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/ldb-mem-fix
>>
>> Regarding the reformating:
>> I'd like to push this patch
>> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=464ea4c0ac1318287bcf3985efeae34c3ed8b521
>> which explains good and bad comment example.
> 
>  Comments should always use the standard C syntax.  C++
> -style comments are not currently allowed.
> +style comments are not currently allowed. The lines before
> +a comment should be empty. If the comment directly belongs
> +to the following code, there should be no empty line after
> +the comment. In case the comment contains a summary of
> +mutliple following code blogs.
> 
> s/mutliple/multiple/
> s/blogs/blocks/
> 
> Also, the last sentence is not a complete sentence.  Did you mean the following?
> 
> "If the comment directly belongs to the following code, there should
> be no empty line after
> the comment, except if the comment contains a summary of multiple
> following code blocks."
> 

Yes, thanks!

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100710/8f950681/attachment.pgp>