[SCM] Samba Shared Repository - branch master updated
Jeremy Allison
jra at samba.org
Thu Jul 8 11:34:05 MDT 2010
On Thu, Jul 08, 2010 at 01:18:11PM +0200, Volker Lendecke wrote:
> On Wed, Jul 07, 2010 at 08:09:45PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> > via 90b1a1d... s3: Add SMB2 performance counters.
> > from 609b865... s4-dsdb/util: Reorder DSDB_FLAG_* checks
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit 90b1a1d29623c6c2abc86e2571b535a7832dd376
> > Author: Ira Cooper <samba at ira.wakeful.net>
> > Date: Thu Jul 1 17:51:41 2010 -0400
> >
> > s3: Add SMB2 performance counters.
> >
> > A performance counter was added for every base type of SMB2 op.
>
> Can we get rid of these very, very strange
> PROFILE_AND_RETURN macros? Function calls (that's what
> macro calls look like) doing magic returns and allocating
> variables on the stack are bound to cause trouble very, very
> quickly.
Ok, I'll let Ira propose a change for his patch. I wasn't
100% sold on them but they did seem harmless to me. I get
your point though.
Jeremy.
More information about the samba-technical
mailing list