[PATCH] s4-drs: Reads uSNUrgent and sets Urgent Replication Bit

[Fernando J V da Silva]

Hi Tridge!

Sorry for the late reply... I've just pushed the correct patch to my tree.

Best Regards,

-- 
Fernando J V da Silva
M Sc Computer Science Student
Institute of Computing, State University of Campinas
+55 15 8801-2165


2010/1/16  <tridge at samba.org>:
> Hi Fernando,
>
> In your test for whether to set the urgent bit, you do this:
>
>        if (uSNHighest == uSNUrgent) {
>           .... treat as urgent ...
>        }
>
> I don't think that is correct. I think the test should be:
>
>        if (sdsa->notify_uSN < uSNUrgent) {
>           ... treat as urgent ...
>        }
>
> the logic is that we say it is urgent if the remote DC has not
> replicated with this NC since the last urgent change to the database.
>
> Can you fix that up, then rebase on master and push to your tree
> again?
>
> Cheers, Tridge
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-drs-Reads-uSNUrgent-and-sets-Urgent-Replication.patch
Type: text/x-patch
Size: 3936 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100122/5b90c60b/attachment.bin>