[PATCH] s4-drs: Reads uSNUrgent and sets Urgent Replication Bit

tridge at samba.org tridge at samba.org
Fri Jan 15 21:01:36 MST 2010

Hi Fernando,

In your test for whether to set the urgent bit, you do this:

        if (uSNHighest == uSNUrgent) {
	   .... treat as urgent ...

I don't think that is correct. I think the test should be:
 	if (sdsa->notify_uSN < uSNUrgent) {
	   ... treat as urgent ...

the logic is that we say it is urgent if the remote DC has not
replicated with this NC since the last urgent change to the database. 

Can you fix that up, then rebase on master and push to your tree

Cheers, Tridge

More information about the samba-technical mailing list