[SCM] Samba Shared Repository - branch master updated

[Stefan (metze) Metzmacher]

Jeremy Allison schrieb:
> On Tue, Feb 09, 2010 at 07:22:35PM +0100, Stefan (metze) Metzmacher wrote:
>> Jeremy Allison schrieb:
>>> On Tue, Feb 09, 2010 at 12:00:55PM -0600, Stefan Metzmacher wrote:
>>>> The branch, master has been updated
>>>>        via  1686a5e... s3:smbd: Fix really ugly bool vs. int bug!!!
>>> Oh I missed that in the review, sorry :-(. We'll need that
>>> in 3.5.0. Can you attach to the bug report and get Karolin
>>> to push ?
>> That bug was there since 2007!...
>>
>> commit 30191d1a5704ad2b158386b511558972d539ce47
>> Author:     Jeremy Allison <jra at samba.org>
>> AuthorDate: Thu Oct 18 17:40:25 2007 -0700
>> Commit:     Jeremy Allison <jra at samba.org>
>> CommitDate: Thu Oct 18 17:40:25 2007 -0700
>>
>>     RIP BOOL. Convert BOOL -> bool. I found a few interesting
>>     bugs in various places whilst doing this (places that assumed
>>     BOOL == int). I also need to fix the Samba4 pidl generation
>>     (next checkin).
>>     Jeremy.
> 
> Oh thanks a bunch :-). Ok, now I *know* it was my fault :-).
> 
> How did you find the bug btw ?

I first thought it's a bug in the qsort code,
then I tried ldb_qsort() and while giving the comparison fn
an additional argument I noticed the bool...

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100210/4f5905d2/attachment.pgp>