Samba build is broken

Brad Hards bradh at frogmouth.net
Tue Aug 31 17:01:52 MDT 2010


On Wednesday, September 01, 2010 07:07:00 am Björn JACKE wrote:
> On 2010-08-31 at 17:08 +0300 Zahari Zahariev sent off:
> > http://pastebin.com/h6zzQg1g
> > 
> > Can you fix that?
> 
> didn't see that here, sorry for the breakage. I've reverted it for now.
There appears to be more problems.

OpenChange uses a standalone build of ldb (i.e. we use it outside of the samba 
server), and the build for that is broken in ldbtest.c

[58/74] Compiling tools/ldbtest.c
../tools/ldbtest.c: In function ‘_start_timer’:
../tools/ldbtest.c:48: error: implicit declaration of function 
‘clock_gettime_mono’
Waf: Leaving directory 
`/home/buildslave1/buildbot/everything/build/samba4/source4/lib/ldb/bin'
Build failed:  -> task failed (err #1): 
	{task: cc ldbtest.c -> ldbtest_35.o}
make: *** [all] Error 1

Fixing the declaration is easy, but I'm not sure how to link to the 
appropriate subsystem (LIBSAMBA-UTIL) in a standalone build.

I tried this:
index a885b80..8c4f377 100644
--- a/source4/lib/ldb/tools/ldbtest.c
+++ b/source4/lib/ldb/tools/ldbtest.c
@@ -39,6 +39,7 @@
 
 #include "ldb.h"
 #include "tools/cmdline.h"
+#include "lib/util/time.h"
 
 static struct timespec tp1,tp2;
 static struct ldb_cmdline *options;
diff --git a/source4/lib/ldb/wscript b/source4/lib/ldb/wscript
index 3dd4547..ecdc623 100644
--- a/source4/lib/ldb/wscript
+++ b/source4/lib/ldb/wscript
@@ -203,7 +203,7 @@ def build(bld):
                          manpages='man/%s.1' % t)
 
     # ldbtest doesn't get installed
-    bld.SAMBA_BINARY('ldbtest', 'tools/ldbtest.c', deps='LIBLDB_CMDLINE',
+    bld.SAMBA_BINARY('ldbtest', 'tools/ldbtest.c', deps='LIBLDB_CMDLINE 
LIBSAMBA-UTIL',
                      install=False)

but then I get
Checking project rules ...
Unknown dependency LIBSAMBA-UTIL in ldbtest.objlist

[You can see the results of periodic builds of the exact configuration we use 
at http://buildbot.openchange.org]

Brad


More information about the samba-technical mailing list