[PATCH] Merging the privilege code

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 27 01:15:11 MDT 2010

On Fri, Aug 27, 2010 at 08:49:26AM +0200, Volker Lendecke wrote:
> Just so that it's not lost in irclog: I don't like making
> the privilege mask a simple uint64_t. I know it is very
> unlikely that we will ever have more than 64 privileges, but
> in S3 we currently have an easily expandable struct. I would
> not like to lose the clarity of the typedef. I would prefer
> a "struct se_priv", because that is the Samba way to express
> special designation of a data type. I don't mind changing
> the current contents of that struct, but I don't feel well
> with losing special type designation.

Another argument in favor of a struct: Type safety. We even
have NTSTATUS (which really is just a uint32 even) as a
struct, Tridge went through great pains to make it one, and
this revealed quite a few bugs.


More information about the samba-technical mailing list