[PATCH] Merging the privilege code

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 27 00:49:26 MDT 2010

On Fri, Aug 27, 2010 at 04:19:34PM +1000, Andrew Bartlett wrote:
> Aside from the upgrade code, I think this is ready for review.  I oddly
> get two failures on UID-REGRESSION-TEST, and what I think is a failure
> in the selftest code showing up in RAP-SAM, but other than that it
> passes 'make test' in samba3.  (it's not the first time I've seen it,
> but while I suspect it's unrelated, I'll investigate)
> It also passes 'make test' in Samba4, with the odd exception of a
> privileges failure that I'm struggling to reproduce.  I'm sure it's not
> related ;-)
> It is a very long (36 patch) series of commits, because I've followed
> the advise I've been given so often in the past, and broken up the
> changes as much as I've felt practical.  This should make it much easier
> to review - most of the changes are renames of types, variables or
> structures. 
> Once this is in, I'll follow up with ACL experts about the small
> differences between the access check functions in source3 and source4,
> so that these can also be merged.

Just so that it's not lost in irclog: I don't like making
the privilege mask a simple uint64_t. I know it is very
unlikely that we will ever have more than 64 privileges, but
in S3 we currently have an easily expandable struct. I would
not like to lose the clarity of the typedef. I would prefer
a "struct se_priv", because that is the Samba way to express
special designation of a data type. I don't mind changing
the current contents of that struct, but I don't feel well
with losing special type designation.


More information about the samba-technical mailing list