Patch: Better integration with GAMIN.

[Ira Cooper]

Is this more along the lines you are looking for Volker?

-Ira

commit f5f906a206557bc3c4032ea128595a6fd06e48ab
Author: Ira Cooper <samba at ira.wakeful.net>
Date:   Tue Apr 13 09:21:48 2010 -0400

    Add support for FAMNoExists to vfs_notify_fam.

    This will make GAMIN behave better with samba.

    -Ira

diff --git a/source3/configure.in b/source3/configure.in
index a9b9e47..4e6e5d2 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -2589,18 +2589,19 @@ if test x$enable_fam != xno; then
         # On IRIX, libfam requires libC, but other FAM implementations
        # might not need it.
         AC_CHECK_LIB(fam, FAMOpen2,
-            [samba_cv_HAVE_LIBFAM=yes; SMB_FAM_LIBS="-lfam"],
+            [samba_cv_HAVE_LIBFAM=yes; SMB_FAM_LIBS="-lfam";
+            AC_DEFINE(HAVE_FAMOPEN2, 1, Define to 1 if there is support for FAM
             [samba_cv_HAVE_LIBFAM=no])

         if test x"$samba_cv_HAVE_LIBFAM" = x"no" ; then
             samba_fam_xtra=-lC
             AC_CHECK_LIB_EXT(fam, samba_fam_xtra, FAMOpen2,
-                [samba_cv_HAVE_LIBFAM=yes; SMB_FAM_LIBS="-lfam -lC"],
+                [samba_cv_HAVE_LIBFAM=yes; SMB_FAM_LIBS="-lfam -lC";
+               AC_DEFINE(HAVE_FAMOPEN2, 1, Define to 1 if there is support for
                 [samba_cv_HAVE_LIBFAM=no])
             unset samba_fam_xtra
         fi
     fi
-
     if test x"$samba_cv_HAVE_LIBFAM" = x"yes" ; then
         default_shared_modules="$default_shared_modules vfs_notify_fam"
         AC_TRY_COMPILE([#include <fam.h>],
@@ -2610,6 +2611,11 @@ if test x$enable_fam != xno; then
                     [])
     fi



On Mon, Apr 12, 2010 at 3:56 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Mon, Apr 12, 2010 at 12:47:43PM -0400, Ira Cooper wrote:
>> This is a minor change to make GAMIN more efficient when used with samba.
>>
>> I couldn't find another #define to use other than the header guard.  I
>> consider it ugly, but I couldn't find another way to conditionalize
>> code.
>>
>> If you have questions, please feel free to ask.
>
> Would an autoconf check for FAMNoExists also work for you?
> Along the lines of the existing FAM check in configure.in,
> just as an example:
>
>        AC_TRY_COMPILE([#include <fam.h>],
>                    [enum FAMCodes code = FAMChanged;],
>                    AC_DEFINE(HAVE_FAM_H_FAMCODES_TYPEDEF, 1,
>                        [Whether fam.h contains a typedef for enum FAMCodes]),
>                    [])
>
> You might want to adapt that to your needs...
>
> Thanks,
>
> Volker
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkvDet4ACgkQbZMKAi3WUkleRgCgmoBlxpbgqQYreAPZu2XRwDxo
> kuMAoItBVC9pyWqydcl/mu0/0DIyqB2A
> =rCGR
> -----END PGP SIGNATURE-----
>
>