s4:prefer "samdb_*_dn" basedn calls over the "ldb_get_*_dn" functions

Andrew Bartlett abartlet at samba.org
Mon Apr 12 16:35:38 MDT 2010


On Mon, 2010-04-12 at 11:50 -0500, Matthias Dieter Wallnöfer wrote:

> commit 98ce053efdf8f28aa0480663c0094fc9ca8939e1
> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> Date:   Mon Apr 12 13:43:43 2010 +0200
> 
>     s4:prefer "samdb_*_dn" basedn calls over the "ldb_get_*_dn" functions
>     
>     Purely cosmetic change.

Matthias,

I actually think we should be doing the reverse.  Now that these
functions are in LDB, we should slowly eliminate the wrappers.  That
way, Samba4 isn't so 'special' any more.

Similarly, I would seek to eliminate the gendb_search() calls (mostly
replacing those with another wrapper - dsdb_search()). 

BTW, could you start committing using your samba.org address?  We have
hooks in the build farm and other places that try not to spam non-team
members, and using your @samba.org address also makes it clearer that
you are committing as a team member. 

Thanks, 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100413/be653494/attachment.pgp>


More information about the samba-technical mailing list