[PATCH] Fix tsocket on solaris

Stefan (metze) Metzmacher metze at samba.org
Wed Apr 7 11:17:28 MDT 2010

Stefan (metze) Metzmacher schrieb:
> Stefan (metze) Metzmacher schrieb:
>> Andrew Bartlett schrieb:
>>> Solaris seems to error out (EINVAL) if sendto has a socklen parameter
>>> that isn't the same as the sizeof() for the relevant socket type.
>>> That is, we can't use sizeof(struct sockaddr_storage).
>>> This does not show up on the build farm, as we use socket_wrapper, which
>>> plays other games.
>>> Please find attached and review my proposed patch, which instead tries
>>> to keep the length alongside the struct sockaddr at all times. 
>> here's my full version of the patch.
>> It compiles, but I haven't done any real testing.
>> make test failed, but I'm not sure the failure is really related.

I think this version should be ok, it fixes a pointer vs. stack variable
bug in the recvfrom_handler.

But it still fails with the same error, maybe it's not really related...
I'll do more tests tomorrow.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tsocket_bsd-Always-use-a-real-length-for-the-sa_sock.patch
Type: text/x-diff
Size: 7966 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100407/367b60fc/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100407/367b60fc/attachment.pgp>

More information about the samba-technical mailing list