[PATCH] Fix tsocket on solaris

Stefan (metze) Metzmacher metze at samba.org
Wed Apr 7 09:59:58 MDT 2010


Stefan (metze) Metzmacher schrieb:
> Andrew Bartlett schrieb:
>> Solaris seems to error out (EINVAL) if sendto has a socklen parameter
>> that isn't the same as the sizeof() for the relevant socket type.
>>
>> That is, we can't use sizeof(struct sockaddr_storage).
>>
>> This does not show up on the build farm, as we use socket_wrapper, which
>> plays other games.
>>
>> Please find attached and review my proposed patch, which instead tries
>> to keep the length alongside the struct sockaddr at all times. 
> 
> here's my full version of the patch.
> 
> It compiles, but I haven't done any real testing.
> make test failed, but I'm not sure the failure is really related.

I think it is related, but I don't know why set.

/home/metze/master4/source4/scripting/bin/samba_dnsupdate: Traceback
(most recent call last):
/home/metze/master4/source4/scripting/bin/samba_dnsupdate:   File
"/home/metze/master4/source4/scripting/bin/samba_dnsupdate", line 295,
in <module>
/home/metze/master4/source4/scripting/bin/samba_dnsupdate:
get_credentials(lp)
/home/metze/master4/source4/scripting/bin/samba_dnsupdate:   File
"/home/metze/master4/source4/scripting/bin/samba_dnsupdate", line 97, in
get_credentials
/home/metze/master4/source4/scripting/bin/samba_dnsupdate:
creds.get_named_ccache(lp, ccachename)
/home/metze/master4/source4/scripting/bin/samba_dnsupdate: RuntimeError:
kinit for LOCALDC1$@SAMBA.EXAMPLE.COM failed (Cannot contact any KDC for
requested realm: unable to reach any KDC in realm SAMBA.EXAMPLE.COM)
/home/metze/master4/source4/scripting/bin/samba_dnsupdate:
dsdb/dns/dns_update.c:234: Failed DNS update - NT_STATUS_ACCESS_DENIED

at the start of make test.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100407/c8c03e24/attachment.pgp>


More information about the samba-technical mailing list